srebhan commented on PR #34331: URL: https://github.com/apache/arrow/pull/34331#issuecomment-1463736232
@zeroshade I pushed an update containing fixes to most of your comments above, the unification of the drivers and placement of the driver in a `driver` subdir. I do have one question to the schema usage (see response to your comment). I'll probably be the wrong person to implement a schema mock, but I'm willing to test if someone implements this. Regarding the other open points I suggest to first get this PR ready and merged. I'm then willing to work on the following items as follow-up PRs: 1. TLS configuration 2. parameterization of the memory allocator (if we really want to do this without need) 3. mock schema generation for SQLite example (not sure if I can find the time for this) What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
