jorisvandenbossche commented on code in PR #117: URL: https://github.com/apache/arrow-nanoarrow/pull/117#discussion_r1132414520
########## python/.gitignore: ########## @@ -18,7 +18,8 @@ src/nanoarrow/nanoarrow.c src/nanoarrow/nanoarrow.h -src/nanoarrow/*.cpp +src/nanoarrow/nanoarrow_c.pxd Review Comment: Ah, that's also a good idea, if we are OK with having a python specific file in that directory. Then the automated bot could generate it together with the .c and .h file? For local development, doesn't have that the same potential drawback of not using the correct one? (if you edited the c sources) Although the same is true currently for the .c and .h files, so I suppose the idea is to still keep the cmake build step to ensure you use the latest for local development? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
