icexelloss commented on code in PR #34311: URL: https://github.com/apache/arrow/pull/34311#discussion_r1132498738
########## cpp/src/arrow/compute/exec/aggregate_node.cc: ########## @@ -169,20 +185,79 @@ void AggregatesToString(std::stringstream* ss, const Schema& input_schema, *ss << ']'; } +// Handle the input batch +// If a segment is closed by this batch, then we output the aggregation for the segment +// If a segment is not closed by this batch, then we add the batch to the segment +template <typename BatchHandler> +Status HandleSegments(std::unique_ptr<RowSegmenter>& segmenter, const ExecBatch& batch, Review Comment: nvm - looks like github diff issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
