ozankabak commented on PR #3824: URL: https://github.com/apache/arrow-rs/pull/3824#issuecomment-1464328245
IMO the target-specific selection in this case is straightforward/surgical and I don't immediately see any potential headaches related to this in the future. Given that the only target this doesn't support this is WASM, keeping the selection seems OK to me. BTW, I am not categorically against the `append_local` idea as it doesn't really matter for Datafusion -- we will simply enable it there. However, it seems like an avoidable complexity in general. Our initial thinking was to remove the selection when support arrives, and we already discovered [workarounds](https://github.com/synnada-ai/arrow-rs/pull/5) in case we want to support it sooner rather than later. @alamb, @tustvold: Let us know what you think and we can finalize accordingly. Thanks for the reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
