benibus commented on issue #14939: URL: https://github.com/apache/arrow/issues/14939#issuecomment-1464574956
Hi @dinimar. Thanks for taking this on! In your case, each call to `get_children` is expected to return a new `const ChunkedArrayVector*` for each nesting level - whereas the current implementation just returns a single `std::shared_ptr<ChunkedArray>`. To do that, you might want to look into `ChunkedArray::Flatten`. (Keep in mind though, each new vector would need to outlive the scope of `get_children` since it's expected to return a pointer - I'd suggest using a lambda capture for that) Handling tables likely requires some specialized logic compared to record batches due to the fact that they (uniquely) deal with `ChunkedArray`s as opposed to standard `Array`s. Of course, keeping things DRY as possible would be nice - but there will be some differences in implementation. > Does these changes require new additional unit-tests for Table overloads? Yes I'd say so. For `FieldPath::Get` at least. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
