tustvold commented on code in PR #3802:
URL: https://github.com/apache/arrow-rs/pull/3802#discussion_r1133079167
##########
object_store/src/aws/credential.rs:
##########
@@ -84,7 +84,7 @@ const AUTH_HEADER: &str = "authorization";
const ALL_HEADERS: &[&str; 4] = &[DATE_HEADER, HASH_HEADER, TOKEN_HEADER,
AUTH_HEADER];
impl<'a> RequestSigner<'a> {
- fn sign(&self, request: &mut Request) {
+ pub(crate) fn sign(&self, request: &mut Request, include_payload_hash:
bool) {
Review Comment:
Does this need to be an argument or could it be a member like
self.sign_payload?
Also why is this necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
