jaylmiller commented on PR #5554: URL: https://github.com/apache/arrow-datafusion/pull/5554#issuecomment-1465259556
@waynexia thanks for correcting my assumption about how normalized dicts 😀. I've made changes correcting this. There is a bit of hashing required but significantly less than before since we only need to hash once for each value type (instead of hashing every cell). Also since there was now alot of shared logic between the 2 accumulators, i've pulled that out into funcs so both accumulators can use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
