crepererum commented on code in PR #5545:
URL: https://github.com/apache/arrow-datafusion/pull/5545#discussion_r1133692368
##########
datafusion/core/src/physical_plan/file_format/parquet.rs:
##########
@@ -1656,26 +1655,50 @@ mod tests {
object_meta: meta,
partition_values: vec![
ScalarValue::Utf8(Some("2021".to_owned())),
- ScalarValue::Utf8(Some("10".to_owned())),
- ScalarValue::Utf8(Some("26".to_owned())),
+ ScalarValue::UInt8(Some(10)),
+ ScalarValue::Dictionary(
+ Box::new(DataType::UInt16),
+ Box::new(ScalarValue::Utf8(Some("26".to_owned()))),
+ ),
],
range: None,
extensions: None,
};
+ let expected_schema = Schema::new(vec![
+ Field::new("id", DataType::Int32, true),
+ Field::new("bool_col", DataType::Boolean, true),
+ Field::new("tinyint_col", DataType::Int32, true),
Review Comment:
The schema that I get from `infer_schema` (see two statements above)
contains an `Int32`. I haven't touched this code and this is the current state
on `main`. Not saying this is correct though, it might be a pre-existing bug.
Note that the schema wasn't tested before, that's why I added this assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
