westonpace commented on code in PR #34518:
URL: https://github.com/apache/arrow/pull/34518#discussion_r1133910492
##########
cpp/src/arrow/compute/light_array_test.cc:
##########
@@ -216,27 +215,6 @@ TEST(KeyColumnArray, SliceBool) {
}
}
-TEST(KeyColumnArray, FromExecBatch) {
Review Comment:
Hmm, it's a bit odd to have these tests split this way. Do you want to just
move this entire test file to `exec`? Maybe later we can, in a follow-up,
attempt to pull out the utilities that are needed in `exec/test_util.h` so the
entire test file can move out of `exec`.
However, for now, I think it's probably ok that this is tested in exec.
##########
cpp/src/arrow/compute/util_internal.h:
##########
@@ -0,0 +1,31 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "arrow/util/logging.h"
+
+namespace arrow {
+namespace util {
+
+template <typename T>
+void CheckAlignment(const void* ptr) {
Review Comment:
Yes, internal is correct for this, good catch. `exec/util.h` has always
been "implicitly internal" and I've been wanting to rename it forever but
hadn't quite gotten around to it. This is a good start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
