alamb commented on code in PR #5517:
URL: https://github.com/apache/arrow-datafusion/pull/5517#discussion_r1134194707
##########
datafusion/optimizer/src/unwrap_cast_in_comparison.rs:
##########
@@ -1070,4 +1118,162 @@ mod tests {
}
}
}
+
+ #[test]
+ fn test_try_cast_literal_to_timestamp() {
+ // same timestamp
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampNanosecond(Some(123456), None),
+ &DataType::Timestamp(TimeUnit::Nanosecond, None),
+ )
+ .unwrap()
+ .unwrap();
+
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampNanosecond(Some(123456), None)
+ );
+
+ // TimestampNanosecond to TimestampMicrosecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampNanosecond(Some(123456), None),
+ &DataType::Timestamp(TimeUnit::Microsecond, None),
+ )
+ .unwrap()
+ .unwrap();
+
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampMicrosecond(Some(123), None)
+ );
+
+ // TimestampNanosecond to TimestampMillisecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampNanosecond(Some(123456), None),
+ &DataType::Timestamp(TimeUnit::Millisecond, None),
+ )
+ .unwrap()
+ .unwrap();
+
+ assert_eq!(new_scalar, ScalarValue::TimestampMillisecond(Some(0),
None));
+
+ // TimestampNanosecond to TimestampSecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampNanosecond(Some(123456), None),
+ &DataType::Timestamp(TimeUnit::Second, None),
+ )
+ .unwrap()
+ .unwrap();
+
+ assert_eq!(new_scalar, ScalarValue::TimestampSecond(Some(0), None));
+
+ // TimestampMicrosecond to TimestampNanosecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampMicrosecond(Some(123), None),
+ &DataType::Timestamp(TimeUnit::Nanosecond, None),
+ )
+ .unwrap()
+ .unwrap();
+
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampNanosecond(Some(123000), None)
+ );
+
+ // TimestampMicrosecond to TimestampMillisecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampMicrosecond(Some(123), None),
+ &DataType::Timestamp(TimeUnit::Millisecond, None),
+ )
+ .unwrap()
+ .unwrap();
+
+ assert_eq!(new_scalar, ScalarValue::TimestampMillisecond(Some(0),
None));
+
+ // TimestampMicrosecond to TimestampSecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampMicrosecond(Some(123456789), None),
+ &DataType::Timestamp(TimeUnit::Second, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(new_scalar, ScalarValue::TimestampSecond(Some(123), None));
+
+ // TimestampMillisecond to TimestampNanosecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampMillisecond(Some(123), None),
+ &DataType::Timestamp(TimeUnit::Nanosecond, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampNanosecond(Some(123000000), None)
+ );
+
+ // TimestampMillisecond to TimestampMicrosecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampMillisecond(Some(123), None),
+ &DataType::Timestamp(TimeUnit::Microsecond, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampMicrosecond(Some(123000), None)
+ );
+ // TimestampMillisecond to TimestampSecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampMillisecond(Some(123456789), None),
+ &DataType::Timestamp(TimeUnit::Second, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(new_scalar, ScalarValue::TimestampSecond(Some(123456),
None));
+
+ // TimestampSecond to TimestampNanosecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampSecond(Some(123), None),
+ &DataType::Timestamp(TimeUnit::Nanosecond, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampNanosecond(Some(123000000000), None)
+ );
+
+ // TimestampSecond to TimestampMicrosecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampSecond(Some(123), None),
+ &DataType::Timestamp(TimeUnit::Microsecond, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampMicrosecond(Some(123000000), None)
+ );
+
+ // TimestampSecond to TimestampMillisecond
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampSecond(Some(123), None),
+ &DataType::Timestamp(TimeUnit::Millisecond, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(
+ new_scalar,
+ ScalarValue::TimestampMillisecond(Some(123000), None)
+ );
+
+ // overflow
+ let new_scalar = try_cast_literal_to_type(
+ &ScalarValue::TimestampSecond(Some(i64::MAX), None),
+ &DataType::Timestamp(TimeUnit::Millisecond, None),
+ )
+ .unwrap()
+ .unwrap();
+ assert_eq!(new_scalar, ScalarValue::TimestampMillisecond(None, None));
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
