comphead commented on code in PR #5579:
URL: https://github.com/apache/arrow-datafusion/pull/5579#discussion_r1134623082
##########
datafusion/expr/src/utils.rs:
##########
@@ -96,7 +96,44 @@ pub fn expr_to_columns(expr: &Expr, accum: &mut
HashSet<Column>) -> Result<()> {
Expr::ScalarVariable(_, var_names) => {
accum.insert(Column::from_name(var_names.join(".")));
}
- _ => {}
+ // Use explicit pattern match instead of a default
+ // implementation, so that in the future if someone adds
+ // new Expr types, they will check here as well
+ Expr::Alias(_, _)
+ | Expr::Literal(_)
+ | Expr::BinaryExpr { .. }
+ | Expr::Like { .. }
+ | Expr::ILike { .. }
+ | Expr::SimilarTo { .. }
+ | Expr::Not(_)
+ | Expr::IsNotNull(_)
+ | Expr::IsNull(_)
+ | Expr::IsTrue(_)
+ | Expr::IsFalse(_)
+ | Expr::IsUnknown(_)
+ | Expr::IsNotTrue(_)
+ | Expr::IsNotFalse(_)
+ | Expr::IsNotUnknown(_)
+ | Expr::Negative(_)
+ | Expr::Between { .. }
+ | Expr::Case { .. }
+ | Expr::Cast { .. }
+ | Expr::TryCast { .. }
+ | Expr::Sort { .. }
+ | Expr::ScalarFunction { .. }
Review Comment:
nice, so everyone will be guided by compiler when implementing new `Expr`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
