alamb commented on code in PR #5564:
URL: https://github.com/apache/arrow-datafusion/pull/5564#discussion_r1135473896
##########
datafusion/core/src/physical_plan/joins/nested_loop_join.rs:
##########
@@ -87,6 +91,10 @@ pub struct NestedLoopJoinExec {
inner_table: OnceAsync<JoinLeftData>,
/// Information of index and left / right placement of columns
column_indices: Vec<ColumnIndex>,
+ /// Operator-level memory reservation for left data
+ reservation: OperatorMemoryReservation,
+ /// Execution metrics
+ metrics: ExecutionPlanMetricsSet,
Review Comment:
thank you for unifying the metrics at the same time
##########
datafusion/core/src/physical_plan/joins/nested_loop_join.rs:
##########
@@ -1016,4 +1134,56 @@ mod tests {
Ok(())
}
+
+ #[tokio::test]
+ async fn test_overallocation() -> Result<()> {
+ let left = build_table(
+ ("a1", &vec![1, 2, 3, 4, 5, 6, 7, 8, 9, 0]),
+ ("b1", &vec![1, 2, 3, 4, 5, 6, 7, 8, 9, 0]),
+ ("c1", &vec![1, 2, 3, 4, 5, 6, 7, 8, 9, 0]),
+ );
+ let right = build_table(
+ ("a2", &vec![10, 11]),
+ ("b2", &vec![12, 13]),
+ ("c2", &vec![14, 15]),
+ );
+ let filter = prepare_join_filter();
+
+ let join_types = vec![
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
