spebern commented on code in PR #3856:
URL: https://github.com/apache/arrow-rs/pull/3856#discussion_r1135499485
##########
arrow-data/src/bit_iterator.rs:
##########
@@ -16,8 +16,67 @@
// under the License.
use arrow_buffer::bit_chunk_iterator::{UnalignedBitChunk,
UnalignedBitChunkIterator};
+use arrow_buffer::bit_util::{ceil, get_bit_raw};
use std::result::Result;
+/// Iterator over the bits within a packed bitmask
+///
+/// To efficiently iterate over just the set bits see [`BitIndexIterator`] and
[`BitSliceIterator`]
+pub struct BitIterator<'a> {
+ buffer: &'a [u8],
+ current_offset: usize,
+ end_offset: usize,
+}
+
+impl<'a> BitIterator<'a> {
+ /// Create a new [`BitSliceIterator`] from the provide `buffer`,
Review Comment:
Should this be `provided`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
