[GitHub] [arrow] mapleFU commented on a diff in pull request #34555: GH-34556: [C++]Add prefix 'ACT_' for 'arrow::Compression::type' to avoid naming conflicts

[via GitHub]

mapleFU commented on code in PR #34555:
URL: https://github.com/apache/arrow/pull/34555#discussion_r1135516266


##########
cpp/src/arrow/util/type_fwd.h:
##########
@@ -45,17 +45,18 @@ struct Scope;
 
 struct Compression {
   /// \brief Compression algorithm
+  //   prefix 'ACT'(arrow compression type) to avoid nameing conflicts.
   enum type {

Review Comment:
   Why don't:
   
   ```
   enum class Compression : int32_t {
     /// \brief Compression algorithm
     UNCOMPRESSED,
     SNAPPY,
     GZIP,
     BROTLI,
     ZSTD,
     LZ4,
     LZ4_FRAME,
     LZO,
     BZ2,
     LZ4_HADOOP
   };
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org