tustvold commented on code in PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#discussion_r1135519695
##########
datafusion/core/tests/sql/timestamp.rs:
##########
@@ -1411,14 +1411,14 @@ async fn cast_timestamp_before_1970() -> Result<()> {
assert_batches_eq!(expected, &actual);
- let sql = "select cast('1969-01-01T00:00:00.1Z' as timestamp);";
+ let sql = "select cast('1969-01-01T00:00:00.100Z' as timestamp);";
Review Comment:
An error, it was a mis-reading of the RFC spec, I thought it restricted to
multiples of 3 for subsecond precision, I'm working on a fix. It is somewhat
amusing that chrono doesn't actually have any tests for this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
