alamb commented on code in PR #5599: URL: https://github.com/apache/arrow-datafusion/pull/5599#discussion_r1135654440
########## datafusion/core/tests/sqllogictests/test_files/aggregate.slt: ########## @@ -1058,73 +1058,44 @@ NULL 4 29 1.260869565217 123 -117 23 NULL 5 -194 -13.857142857143 118 -101 14 NULL NULL 781 7.81 125 -117 100 +# TODO this querys output is non determinisitic (the order of the elements +# differs run to run +# # csv_query_array_agg_distinct # query T # SELECT array_agg(distinct c2) FROM aggregate_test_100 # ---- # [4, 2, 3, 5, 1] -# TODO: aggregate_timestamps_sum - -# aggregate_timestamps_count -# query IIII -# SELECT count(nanos), count(micros), count(millis), count(secs) FROM t -# ---- -# 3 3 3 3 - -# aggregate_timestamps_min -# query TTTT -# SELECT min(nanos), min(micros), min(millis), min(secs) FROM t -# ---- -# 2011-12-13T11:13:10.123450 2011-12-13T11:13:10.123450 2011-12-13T11:13:10.123 2011-12-13T11:13:10 - -# # aggregate_timestamps_max -# query TTTT -# SELECT max(nanos), max(micros), max(millis), max(secs) FROM t -# ---- -# 2021-01-01T05:11:10.432 2021-01-01T05:11:10.432 2021-01-01T05:11:10.432 2021-01-01T05:11:10 - -# TODO: aggregate_times_sum - -# TODO: aggregate_times_count - -# TODO: aggregate_times_min - -# TODO: aggregate_times_max - -# TODO: aggregate_timestamps_avg - # aggregate_time_min_and_max query TT select min(t), max(t) from (select '00:00:00' as t union select '00:00:01' union select '00:00:02') ---- 00:00:00 00:00:02 # aggregate_decimal_min -query R -select min(c1) from d_table +query RT +select min(c1), arrow_typeof(min(c1)) from d_table ---- --100.009 +-100.009 Decimal128(10, 3) # aggregate_decimal_max -query R -select max(c1) from d_table +query RT +select max(c1), arrow_typeof(max(c1)) from d_table ---- -110.009 +110.009 Decimal128(10, 3) -# FIX: doesn't check datatype Review Comment: Added type check per comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
