alamb commented on code in PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#discussion_r1135698258
##########
datafusion/core/tests/sql/timestamp.rs:
##########
@@ -1411,14 +1411,14 @@ async fn cast_timestamp_before_1970() -> Result<()> {
assert_batches_eq!(expected, &actual);
- let sql = "select cast('1969-01-01T00:00:00.1Z' as timestamp);";
+ let sql = "select cast('1969-01-01T00:00:00.100Z' as timestamp);";
Review Comment:
I would tend to think this regression should block the upgrade of
datafusion, but would defer to others.
maybe we can mark this PR as "ready for review" to get some other opinions 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
