alamb commented on code in PR #3858:
URL: https://github.com/apache/arrow-rs/pull/3858#discussion_r1135702603
##########
arrow-cast/src/parse.rs:
##########
@@ -983,6 +987,29 @@ mod tests {
)
}
+ #[test]
+ fn string_to_timestamp_chrono() {
+ let cases = [
+ "2020-09-08T13:42:29Z",
+ "1969-01-01T00:00:00.1Z",
+ "2020-09-08T12:00:12.12345678+00:00",
Review Comment:
What do you think about covering all of the various precision cases (aka
```
"2020-09-08T12:00:12+00:00",
"2020-09-08T12:00:12.1+00:00",
"2020-09-08T12:00:12.12+00:00",
"2020-09-08T12:00:12.123+00:00",
"2020-09-08T12:00:12.1234+00:00",
...
"2020-09-08T12:00:12.12345678+00:00",
```
as there is explicit handling for each of them above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
