ygf11 commented on code in PR #5567: URL: https://github.com/apache/arrow-datafusion/pull/5567#discussion_r1136705258
########## datafusion/core/tests/sqllogictests/test_files/join_disable_repartition_joins.slt: ########## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +########## +## Join Tests +########## + +# turn off repartition_joins +statement ok +set datafusion.optimizer.repartition_joins = false; + +include ./join.slt + +# turn on repartition_joins +statement ok +set datafusion.optimizer.repartition_joins = true; Review Comment: > do you guys think we should create a .slt file per use case like disabled repartition join? or reuse join.slt? I think it's worth creating this file now. I first tried adding everything to `join.slt` and found a lot of duplicated code, since most tests need to be run twice. ```sql # query x statement ok set datafusion.optimizer.repartition_joins = false; query ITI rowsort SELECT xxx ---- a a a # switch to another config statement ok set datafusion.optimizer.repartition_joins = true; query ITI rowsort SELECT xxx ---- a a a ``` Using include reduces a lot of codes, originally the addition was `1100+`, now it is `655`. For the tests whose setting is complex, we can also add them to `join.slt`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
