lidavidm commented on code in PR #511: URL: https://github.com/apache/arrow-adbc/pull/511#discussion_r1137205285
########## r/adbcpostgresql/R/adbcpostgresql-package.R: ########## @@ -0,0 +1,142 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +#' @keywords internal +#' @aliases NULL +"_PACKAGE" + +## usethis namespace: start +#' @useDynLib adbcpostgresql, .registration = TRUE +## usethis namespace: end +NULL + +#' ADBC SQLite3 Driver +#' +#' @inheritParams adbcdrivermanager::adbc_database_init +#' @inheritParams adbcdrivermanager::adbc_connection_init +#' @inheritParams adbcdrivermanager::adbc_statement_init +#' @param uri A URI to a database path or ":memory:" for an in-memory database. Review Comment: PostgreSQL supports in-memory databases? :exploding_head: ########## r/adbcpostgresql/src/database.cc: ########## Review Comment: We vendored only one of the driver files? ########## r/adbcpostgresql/README.Rmd: ########## @@ -0,0 +1,82 @@ +--- +output: github_document +--- + +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +<!-- README.md is generated from README.Rmd. Please edit that file --> + +```{r, include = FALSE} +knitr::opts_chunk$set( + collapse = TRUE, + comment = "#>", + fig.path = "man/figures/README-", + out.width = "100%" +) +``` + +# adbcpostgresql + +<!-- badges: start --> +<!-- badges: end --> + +The goal of adbcdrivermanager is to provide a low-level developer-facing interface +to the Arrow Database Connectivity (ADBC) SQLite driver. Review Comment: ```suggestion to the Arrow Database Connectivity (ADBC) PostgreSQL driver. ``` ########## r/adbcpostgresql/README.Rmd: ########## @@ -0,0 +1,82 @@ +--- +output: github_document +--- + +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +<!-- README.md is generated from README.Rmd. Please edit that file --> + +```{r, include = FALSE} +knitr::opts_chunk$set( + collapse = TRUE, + comment = "#>", + fig.path = "man/figures/README-", + out.width = "100%" +) +``` + +# adbcpostgresql + +<!-- badges: start --> +<!-- badges: end --> + +The goal of adbcdrivermanager is to provide a low-level developer-facing interface +to the Arrow Database Connectivity (ADBC) SQLite driver. + +## Installation + +You can install the development version of adbcpostgresql from [GitHub](https://github.com/) with: + +``` r +# install.packages("remotes") +remotes::install_github("apache/arrow-adbc/r/adbcpostgresql") +``` + +## Example + +This is a basic example which shows you how to solve a common problem: + +```{r example} Review Comment: ah, I guess the example needs updating still? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
