westonpace commented on code in PR #34249:
URL: https://github.com/apache/arrow/pull/34249#discussion_r1137398807
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -402,6 +402,14 @@ class ARROW_EXPORT OrderBySinkNodeOptions : public
SinkNodeOptions {
SortOptions sort_options;
};
+class ARROW_EXPORT OrderByNodeOptions : public ExecNodeOptions {
+ public:
+ static constexpr std::string_view kName = "order_by";
+ explicit OrderByNodeOptions(Ordering ordering) :
ordering(std::move(ordering)) {}
+
+ Ordering ordering;
Review Comment:
Yes, `SortOptions` and `Ordering` are equivalent. However, `Ordering`
doesn't extend from `FunctionOptions`. I wasn't sure how to proceed here so I
ended up creating a new type. It felt a bit weird for a `FunctionOptions` to
be used in exec plans completely unrelated to running functions. Although, to
play devil's advocate, `FunctionOptions` is "mostly" just a marker interface
and doesn't really prevent anything from working so I would open to just using
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
