tustvold commented on code in PR #5612:
URL: https://github.com/apache/arrow-datafusion/pull/5612#discussion_r1137407741
##########
datafusion/core/src/dataframe.rs:
##########
@@ -627,22 +627,12 @@ impl DataFrame {
/// # }
/// ```
pub async fn count(self) -> Result<usize> {
- let rows = self
- .aggregate(
- vec![],
- vec![datafusion_expr::count(Expr::Literal(ScalarValue::Null))],
- )?
- .collect()
- .await?;
- let len = *rows
- .first()
- .and_then(|r| r.columns().first())
- .and_then(|c| c.as_any().downcast_ref::<Int64Array>())
- .and_then(|a| a.values().first())
- .ok_or(DataFusionError::Internal(
- "Unexpected output when collecting for count()".to_string(),
- ))? as usize;
- Ok(len)
+ let mut stream = self.execute_stream().await?;
Review Comment:
I'm not sure if there is a better way to express this, in particular I'm not
sure what `select count(*) from table` would compile down to, I can't help
feeling there should be a better way to express this for the optimiser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
