metesynnada commented on code in PR #5584:
URL: https://github.com/apache/arrow-datafusion/pull/5584#discussion_r1137496223
##########
datafusion/core/src/dataframe.rs:
##########
@@ -930,10 +932,11 @@ impl DataFrame {
self,
path: &str,
writer_properties: Option<WriterProperties>,
+ save_mode: FileWriterSaveMode,
Review Comment:
Spark made the save mode optional, we can also default to `ErrorIfExists`
mode. Also, we can merge the `WriterProperties` and `FileWriterSaveMode`
structs like in a `ParquetWriterOptions` struct since they are both
configurations, this would abstract the save mode from immediate usage and
contribute the simplicity.
What I mean is we can maybe have something like:
```rust
ParquetWriterOptions {
writer_properties: WriterProperties,
save_mode: FileWriterSaveMode
}
CsvWriterOptions {
dummy_properties: FutureCSVProperties, //dummy
save_mode: FileWriterSaveMode
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
