assignUser commented on code in PR #34563: URL: https://github.com/apache/arrow/pull/34563#discussion_r1137882276
########## matlab/CMakeLists.txt: ########## Review Comment: You define a (for arrow) high cmake minimum version of 3.20 - Do you actually use any features that require this version (on first glance I don't think so?) - Have you considered using FetchContent instead of ExternalProject? [FetchContent](https://cmake.org/cmake/help/latest/module/FetchContent.html) basically gets the content and uses it with `add_subdirectory` this means that it gets configured at the same time as your project -> targets are available vs at build time with ep. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
