mingmwang commented on PR #5554:
URL: 
https://github.com/apache/arrow-datafusion/pull/5554#issuecomment-1471902012

   > I am essentially just running clickbench queries against my PR and against 
main. The only change is I am setting RegionID column to a dict:
   > 
   > ```
   > CREATE EXTERNAL TABLE hits_base
   > STORED AS PARQUET
   > LOCATION 'hits.parquet';
   > CREATE TABLE hits as
   > select 
   >   arrow_cast("RegionID", 'Dictionary(Int32, Utf8)') as "RegionID"
   > ....
   > ```
   > 
   > Do you have any recommendations, @mingmwang ?
   
   I had never check clickbench queries. Maybe you can comment the rule 
`SingleDistinctToGroupBy` and run the benchmark again and see whether there are 
improvements.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to