ildipo commented on code in PR #34575:
URL: https://github.com/apache/arrow/pull/34575#discussion_r1139098658
##########
cpp/src/arrow/testing/generator.cc:
##########
@@ -373,19 +362,15 @@ class GTestDataGeneratorImpl : public GTestDataGenerator {
EXPECT_OK_AND_ASSIGN(auto batches, target_->ExecBatches(rows_per_batch,
num_batches));
return batches;
}
- ::arrow::compute::Declaration SourceNode(int64_t rows_per_batch,
- int num_batches) override {
- EXPECT_OK_AND_ASSIGN(auto source_node,
- target_->SourceNode(rows_per_batch, num_batches));
- return source_node;
- }
std::shared_ptr<::arrow::Table> Table(int64_t rows_per_chunk, int
num_chunks) override {
EXPECT_OK_AND_ASSIGN(auto table, target_->Table(rows_per_chunk,
num_chunks));
return table;
}
std::shared_ptr<::arrow::Schema> Schema() override { return
target_->Schema(); }
+ std::shared_ptr<DataGenerator> Target() { return target_; }
+
Review Comment:
removing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
