alamb commented on code in PR #5603:
URL: https://github.com/apache/arrow-datafusion/pull/5603#discussion_r1140110006
##########
datafusion/common/src/scalar.rs:
##########
@@ -4486,4 +4922,623 @@ mod tests {
assert!(distance.is_none());
}
}
+
+ #[test]
+ fn test_scalar_interval_add() {
+ let cases = [
+ (
+
ScalarValue::IntervalYearMonth(Some(IntervalYearMonthType::make_value(
Review Comment:
I think you can use
https://docs.rs/datafusion/20.0.0/datafusion/scalar/enum.ScalarValue.html#method.new_interval_ym
to reduce this boilerplate substantially
```suggestion
ScalarValue::new_iterval_ym(1, 12)
```
The same for most of the other tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
