tustvold commented on code in PR #3881:
URL: https://github.com/apache/arrow-rs/pull/3881#discussion_r1140358055
##########
arrow-array/src/array/mod.rs:
##########
@@ -96,12 +96,19 @@ pub trait Array: std::fmt::Debug + Send + Sync {
fn as_any(&self) -> &dyn Any;
/// Returns a reference to the underlying data of this array.
+ ///
+ /// This will be deprecated in a future release
[(#3880)](https://github.com/apache/arrow-rs/issues/3880)
fn data(&self) -> &ArrayData;
+ /// Returns the underlying data of this array.
+ fn to_data(&self) -> ArrayData;
+
/// Returns the underlying data of this array.
fn into_data(self) -> ArrayData;
/// Returns a reference-counted pointer to the underlying data of this
array.
+ ///
+ /// This will be deprecated in a future release
[(#3880)](https://github.com/apache/arrow-rs/issues/3880)
Review Comment:
I expect to do so in a future PR, trying to avoid changing all the things at
once :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
