spebern commented on PR #3854: URL: https://github.com/apache/arrow-rs/pull/3854#issuecomment-1473989094
I had a look at what @tustvold suggested and in some cases we'd get another ~40% of performance. However, I only tested this for the 128 bit types, because `lexical` doesn't support 256 bit. I haven't fully grasped yet how to implement `lexical` support for the 256 bit types here yet, but basic things such as shift operations are missing, so it will be a little more work. What do you think of replacing the usage of `BigInt` by https://docs.rs/ethnum/latest/ethnum/ ? `ethnum` is also used by arrow2 and has a more complete implementation when it comes to basic integer operations such as bit shifting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
