felipecrv commented on issue #34382: URL: https://github.com/apache/arrow/issues/34382#issuecomment-1474033910
To add more types we need more specializations of `ReadValueImpl` and `WriteValueImpl` similaryly to how `visit_data_inline.h` does. The current specialization only works on types that have a `::c_type`. There needs to be one for `Binary, String` and another for fixed-size byte-string types like `FixedSizeBinary, Decimal256`. If we can make equality of values a template parameter, `RunEndEncodingLoop` could also be re-used for these specializations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
