felipecrv commented on code in PR #34570:
URL: https://github.com/apache/arrow/pull/34570#discussion_r1140476395
##########
python/pyarrow/tests/test_types.py:
##########
@@ -818,6 +818,19 @@ def test_fields_weakrefable():
assert wr() is None
+def test_run_end_encoded_type():
+ ty = pa.run_end_encoded(pa.int64(), pa.utf8())
+ assert isinstance(ty, pa.RunEndEncodedType)
+ assert ty.run_end_type == pa.int64()
+ assert ty.value_type == pa.utf8()
+
+ with pytest.raises(TypeError):
+ pa.run_end_encoded(pa.int64(), None)
+
+ with pytest.raises(TypeError):
+ pa.run_end_encoded(None, pa.utf8())
Review Comment:
Added. It raises a `ValueError` as the validation comes from the C++ side.
Is that OK or should I write a Python validation that raise `TypeError`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
