amoeba commented on code in PR #34524:
URL: https://github.com/apache/arrow/pull/34524#discussion_r1140694772
##########
r/tests/testthat/test-gcs.R:
##########
@@ -91,6 +91,20 @@ test_that("GcsFileSystem$create() input validation", {
)
})
+test_that("GcsFileSystem$create() can read json_credentials", {
+ # From string
+ fs <- GcsFileSystem$create(json_credentials = "fromstring")
+ expect_equal(fs$options$json_credentials, "fromstring")
+
+ # From disk
+ cred_path <- tempfile()
+ on.exit(unlink(cred_path))
+
+ writeLines("fromdisk", cred_path)
Review Comment:
Done in
https://github.com/apache/arrow/pull/34524/commits/f3018b0351082f26f5bb0c6e69ee87749041a3f4.
I didn't go too wild with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
