mapleFU commented on code in PR #34606:
URL: https://github.com/apache/arrow/pull/34606#discussion_r1140709163
##########
cpp/src/arrow/engine/substrait/options.cc:
##########
@@ -161,10 +161,9 @@ class DefaultExtensionProvider : public
BaseExtensionProvider {
ARROW_ASSIGN_OR_RAISE(auto renamed_schema, schema->WithNames(columns));
auto input_decls = MakeDeclarationInputs(inputs);
ARROW_ASSIGN_OR_RAISE(
- auto decl,
- conv_opts.named_tap_provider(named_tap_rel.kind(), input_decls,
- named_tap_rel.name(),
std::move(renamed_schema)));
- return RelationInfo{{std::move(decl), std::move(renamed_schema)},
std::nullopt};
+ auto decl, conv_opts.named_tap_provider(named_tap_rel.kind(),
input_decls,
+ named_tap_rel.name(),
renamed_schema));
+ return RelationInfo{{std::move(decl), renamed_schema}, std::nullopt};
Review Comment:
(If you'd like to keep it, it's also ok, bugfix is much more important. But
I think we could make it better)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
