bkietz commented on a change in pull request #8728:
URL: https://github.com/apache/arrow/pull/8728#discussion_r528767500
##########
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##########
@@ -427,12 +427,28 @@ void SimpleUnary(KernelContext* ctx, const ExecBatch&
batch, Datum* out) {
//
// static void Call(KernelContext*, const ArrayData& arg0, const ArrayData&
arg1,
// ArrayData* out)
+// static void Call(KernelContext*, const ArrayData& arg0, const Scalar& arg1,
+// ArrayData* out)
+// static void Call(KernelContext*, const Scalar& arg0, const ArrayData& arg1,
+// ArrayData* out)
+// static void Call(KernelContext*, const Scalar& arg0, const Scalar& arg1,
+// Scalar* out)
Review comment:
That's implicit in the contract of ScalarFunctions though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
