mingmwang commented on code in PR #5630:
URL: https://github.com/apache/arrow-datafusion/pull/5630#discussion_r1141588581
##########
datafusion/core/src/physical_optimizer/pipeline_checker.rs:
##########
@@ -78,7 +78,11 @@ impl PipelineStatePropagator {
}
}
-impl TreeNodeRewritable for PipelineStatePropagator {
+impl TreeNode for PipelineStatePropagator {
+ fn get_children(&self) -> Vec<Self> {
+ unimplemented!()
+ }
Review Comment:
I think this is some kind of anti pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
