alamb commented on issue #5157:
URL: 
https://github.com/apache/arrow-datafusion/issues/5157#issuecomment-1476734081

   > What do you think about 🎯 precomputed hash + Arc<str>?
   
   Seems reasonable to me. Maybe as some intermediate state we could have a 
`StringInterner` structure that computed the hash + `Arc<str>` and tried to 
reuse any previously known about. 
   
   Then we could thread through a StringInterner when possible (e.g. on the 
optimizer or the sql planner) but also be able to make these strings easily 
without one (so we could incrementally update the code)
   
   Any such solution, I think, should strive *very hard* to keep the burden of 
working in the DataFusion codebase low (e.g. should be easy to work with for 
anyone used to String, be well documented, etc)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to