assignUser commented on code in PR #34048:
URL: https://github.com/apache/arrow/pull/34048#discussion_r1142829729
##########
r/tools/nixlibs.R:
##########
@@ -99,8 +99,8 @@ download_binary <- function(lib) {
# * Some other string: a "distro-version" that corresponds to a binary that is
# available, to override what this function may discover by default.
# Possible values are:
-# * "centos-7" (gcc 8 (devtoolset), openssl 1, glib 2.17)
-# * "ubuntu-18.04" (gcc 8, openssl 1, glib 2.27)
+# * "centos-7" (gcc 8 (devtoolset), _GLIBCXX_USE_CXX11_ABI=0, openssl 1.0)
Review Comment:
I think renaming the other centos7 binary would communicate the difference
between the two better (without having to look in nixlibs.R)?
```suggestion
# * "centos-7-openssl-1.0" (gcc 8 (devtoolset), _GLIBCXX_USE_CXX11_ABI=0,
openssl 1.0)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
