mustafasrepo commented on code in PR #5661:
URL: https://github.com/apache/arrow-datafusion/pull/5661#discussion_r1142951461
##########
datafusion/core/src/physical_optimizer/sort_enforcement.rs:
##########
@@ -1101,22 +1064,21 @@ mod tests {
sort,
);
- // let filter_exec = sort_exec;
- let physical_plan = window_exec("non_nullable_col", sort_exprs,
filter);
+ let physical_plan = bounded_window_exec("non_nullable_col",
sort_exprs, filter);
Review Comment:
I have changed the `window_exec` with `bounded_window_exec` because the
window expression used in the expression can run with `BoundedWindowAggExec`
(If it were come from sql query it would work with `BoundedWindowExec`). I just
want it to be consistent with general behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
