yahoNanJing commented on code in PR #5543:
URL: https://github.com/apache/arrow-datafusion/pull/5543#discussion_r1143025968
##########
datafusion-cli/src/object_storage.rs:
##########
@@ -43,28 +46,52 @@ impl FromStr for ObjectStoreScheme {
}
}
-#[derive(Debug)]
-pub struct DatafusionCliObjectStoreProvider {}
+#[derive(Debug, Default)]
+pub struct DatafusionCliObjectStoreRegistry {
+ inner: DefaultObjectStoreRegistry,
+}
+
+impl DatafusionCliObjectStoreRegistry {
+ pub fn new() -> Self {
+ Default::default()
+ }
+}
+
+impl ObjectStoreRegistry for DatafusionCliObjectStoreRegistry {
+ fn register_store(
+ &self,
+ key: &str,
Review Comment:
Do we need to consider `port`? Sometimes, it's also important to identify a
url. I don't know whether it's too strict to register with host and scheme. For
previous implementation, for a given url, the key for registration is
`&url[url::Position::BeforeScheme..url::Position::BeforePath]` which may be not
the same as your expectation, although I agree with you it's should not include
the credential info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
