alamb commented on a change in pull request #8715:
URL: https://github.com/apache/arrow/pull/8715#discussion_r529044055
##########
File path: rust/arrow/src/ipc/convert.rs
##########
@@ -268,22 +270,38 @@ pub(crate) fn get_data_type(field: ipc::Field,
may_be_dictionary: bool) -> DataT
if children.len() != 1 {
panic!("expect a list to have one child")
}
- DataType::List(Box::new(children.get(0).into()))
+ let child_field = children.get(0);
+ // returning int16 for now, to test, not sure how to get data type
Review comment:
Perhaps you could change this entire function to something like
```
fn get_data_type_context(field: ipc::Field, may_be_dictionary: bool) ->
DataTypeContext {
...
}
```
And then change
```
pub(crate) fn get_data_type(field: ipc::Field, may_be_dictionary: bool) ->
DataType {
get_data_type_context(field, may_be_dictionary).data_type
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
