tustvold commented on code in PR #3895:
URL: https://github.com/apache/arrow-rs/pull/3895#discussion_r1143956201
##########
arrow-array/src/array/boolean_array.rs:
##########
@@ -96,19 +96,19 @@ impl BooleanArray {
BooleanBuilder::with_capacity(capacity)
}
- /// Returns a `Buffer` holding all the values of this array.
+ /// Returns the underlying [`BooleanBuffer`] holding all the values of
this array.
///
/// Note this doesn't take the offset of this array into account.
Review Comment:
Good spot, whilst technically still true, it is rather misleading
##########
arrow-array/src/array/boolean_array.rs:
##########
@@ -96,19 +96,19 @@ impl BooleanArray {
BooleanBuilder::with_capacity(capacity)
}
- /// Returns a `Buffer` holding all the values of this array.
+ /// Returns the underlying [`BooleanBuffer`] holding all the values of
this array.
///
/// Note this doesn't take the offset of this array into account.
Review Comment:
Good spot, whilst technically still true, it is rather misleading will remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
