yukkit commented on PR #5559:
URL: 
https://github.com/apache/arrow-datafusion/pull/5559#issuecomment-1478948215

   > I plan to move the enumeration logic to the new `Analyzer` and keep the 
constructor logic in the `Aggregate` simple and make the 
constructors(`try_new`(), `try_new_with_schema`()) be consistent.
   > 
   > There are some other grouping expressions related open tickets and I will 
also address them in the following PR.
   > 
   > #5647 #5672
   
   i agree with your proposal


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to