korowa commented on issue #1599: URL: https://github.com/apache/arrow-datafusion/issues/1599#issuecomment-1479083446
> I think we should leverage (reuse) the existing ExteraSorter used in spilling sort After some reading, it looks like that for `MergeJoin` case it makes sense to split spilling part of `ExternalSorter` (responsible for tracking spillable batch buffer) and sorting one -- we already have sorted streams in MJ, so spillable buffer is all that needed -- I believe this implementation could be acceptable and first I'll try to stick to this way. And, further, `ExternalSorter` also seems to be a perfect fit for `HashJoin` -- this is the case where it can be reused as it is for resorting both build and probe sides of HJ. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
