nealrichardson opened a new pull request, #34685: URL: https://github.com/apache/arrow/pull/34685
Closes #34437 and #31982 ### Rationale for this change See #32991 as well. ### What changes are included in this PR? This removes the use of different SinkNodes and R-specific workarounds to support sorting and head/tail, so everything we do in a query should be represented in an ExecPlan. (In a followup, we can simply further and move to the new Declaration class.) Currently, it is not possible to use the FetchNode without specifying an order_by, so we aren't able to remove all of these workarounds. See discussion on #34437. ### Are these changes tested? This is essentially an internal refactor, so we are relying on existing tests to cover the changes, with only minor updates. ### Are there any user-facing changes? The `show_query()` method will print slightly different ExecPlans. It's unclear if there should be changes in performance; running benchmarks would be good but it's also not clear that our benchmarks cover all affected scenarios. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
