zeroshade commented on code in PR #34585:
URL: https://github.com/apache/arrow/pull/34585#discussion_r1145097963
##########
go/arrow/array/extension.go:
##########
@@ -38,7 +38,8 @@ type ExtensionArray interface {
ExtensionType() arrow.ExtensionType
// Storage returns the underlying storage array for this array.
Storage() arrow.Array
-
+ // ValueString returns a string represenation of the value at the given
index for the extension array.
+ ValueString(i int) string
Review Comment:
looks like you need to add a default implementation of `ValueString` for
`ExtensionArrayBase` in order for `staticcheck` not to complain that
`mustEmbedExtensionArrayBase` is unused.
Essentially, `ExtensionArrayBase` needs to meet the `ExtensionArray`
interface for staticcheck linting to be happy. I say the default impl can panic
unless you want to implement the whole `UntypedValue` idea from #34657 here as
part of this PR and then just call that on the underlying storage array as the
default impl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
