mustafasrepo commented on code in PR #5655: URL: https://github.com/apache/arrow-datafusion/pull/5655#discussion_r1145778805
########## benchmarks/README.md: ########## @@ -76,12 +76,54 @@ cargo run --release --bin tpch -- convert --input ./data --output /mnt/tpch-parq Or if you want to verify and run all the queries in the benchmark, you can just run `cargo test`. -### Machine readable benchmark summary +### Comparing results between runs Any `tpch` execution with `-o <dir>` argument will produce a summary file right under the `<dir>` directory. It is a JSON serialized form of all the runs that happened as well as the runtime metadata (number of cores, DataFusion version, etc.). +```shell +$ git checkout main +# generate an output script in /tmp/output_main +$ cargo run --release --bin tpch -- benchmark datafusion --iterations 5 --path /data --format parquet -o /tmp/output_main Review Comment: I think `--path /data` should be replaced with `--path ./data` in this line. Also we can change the `--format parquet` with `--format tbl` (Assuming user doesn't run the conversion script. This is the format of the output of `./tpch-gen.sh`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
