comphead commented on code in PR #5696:
URL: https://github.com/apache/arrow-datafusion/pull/5696#discussion_r1146577285
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -1213,6 +1214,13 @@ pub fn binary(
) -> Result<Arc<dyn PhysicalExpr>> {
let lhs_type = &lhs.data_type(input_schema)?;
let rhs_type = &rhs.data_type(input_schema)?;
+ if (is_utf8_or_large_utf8(lhs_type) && is_timestamp(rhs_type))
Review Comment:
+1 sometime ago we agreed to that logical planner will be a better place for
coercions and coercion checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
