tustvold commented on code in PR #3920:
URL: https://github.com/apache/arrow-rs/pull/3920#discussion_r1146645005
##########
arrow-buffer/src/buffer/mutable.rs:
##########
@@ -89,35 +97,46 @@ impl MutableBuffer {
/// let data = buffer.as_slice_mut();
/// assert_eq!(data[126], 0u8);
/// ```
- #[allow(deprecated)]
pub fn from_len_zeroed(len: usize) -> Self {
- let new_capacity = bit_util::round_upto_multiple_of_64(len);
- let ptr = alloc::allocate_aligned_zeroed(new_capacity);
- Self {
- data: ptr,
- len,
- capacity: new_capacity,
- }
+ let layout = Layout::from_size_align(len, ALIGNMENT).unwrap();
+ let data = match layout.size() {
+ 0 => dangling_ptr(),
+ _ => {
+ // Safety: Verified size != 0
+ let raw_ptr = unsafe { std::alloc::alloc_zeroed(layout) };
+ NonNull::new(raw_ptr).unwrap_or_else(||
handle_alloc_error(layout))
+ }
+ };
+ Self { data, len, layout }
+ }
+
+ /// Create a [`MutableBuffer`] from the provided [`Vec`] without copying
+ #[inline]
+ pub fn from_vec<T: ArrowNativeType>(vec: Vec<T>) -> Self {
+ // Safety
Review Comment:
This is the logic from `Buffer::from_vec`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
