alamb commented on code in PR #3912: URL: https://github.com/apache/arrow-rs/pull/3912#discussion_r1146791259
########## arrow-array/src/builder/generic_byte_run_builder.rs: ########## @@ -368,7 +368,7 @@ pub type LargeStringRunBuilder<K> = GenericByteRunBuilder<K, LargeUtf8Type>; /// /// // Values are polymorphic and so require a downcast. /// let av = array.values(); -/// let ava: &BinaryArray = as_generic_binary_array::<i32>(av.as_ref()); +/// let ava: &BinaryArray = av.as_binary(); Review Comment: I don't necessarily think the code needs to change. I think what helps the most is having some examples around that you can start from. So as always more docs / examples I think the better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
