waynexia commented on code in PR #5707: URL: https://github.com/apache/arrow-datafusion/pull/5707#discussion_r1147176354
########## datafusion/substrait/src/logical_plan/producer.rs: ########## Review Comment: Those import style changes are not necessary, do you think we need to add some rustfmt rules (like [those](https://github.com/GreptimeTeam/greptimedb/blob/develop/rustfmt.toml) in greptimedb)? cc @andygrove @alamb ########## datafusion/substrait/src/logical_plan/producer.rs: ########## @@ -80,7 +83,7 @@ pub fn to_substrait_plan(plan: &LogicalPlan) -> Result<Box<Plan>> { // Return parsed plan Ok(Box::new(Plan { - version: None, // TODO: https://github.com/apache/arrow-datafusion/issues/4949 + version: Some(version::version_with_producer("datafusion")), Review Comment: We have both logical plan and physical plan. Is it needed to distinguish them in this version field? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
